[SYCL][Graph] Moving non-implemented features to extra section #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bensuo
reviewed
Aug 1, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
reble
commented
Aug 1, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Aug 1, 2023
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
| [source, c++] | ||
| ---- | ||
| void | ||
| update(const command_graph<graph_state::modifiable>& graph); |
There was a problem hiding this comment.
There's a section on update on line 534, do we want to move that too?
Also, line 386 in the API overview is the update declaration that can be removed.
There was a problem hiding this comment.
Good catch. I've (re-)moved this part on updating a graph.
…eble/llvm into pablo/opt-out-non-implemented-features
…he Spec (#281) --------- Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
|
Will merge this now, and mark intel#10473 as ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing spec feedback.
For better readability and user experience: Non-implemented features are described in a section future directions and added later. Some descriptions have been replaced by text stubs saying this is not supported.