Skip to content

[SYCL][Graph] Including more feedback from PR #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[SYCL][Graph] Including more feedback from PR #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sycl/source/detail/graph_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,8 @@ bool command_graph<graph_state::modifiable>::begin_recording(
QueueImpl->setCommandGraph(impl);
impl->addQueue(QueueImpl);
return true;
} else if (QueueImpl->getCommandGraph() != impl) {
}
if (QueueImpl->getCommandGraph() != impl) {
throw sycl::exception(sycl::make_error_code(errc::invalid),
"begin_recording called for a queue which is already "
"recording to a different graph.");
Expand Down Expand Up @@ -367,7 +368,8 @@ bool command_graph<graph_state::modifiable>::end_recording(
QueueImpl->setCommandGraph(nullptr);
impl->removeQueue(QueueImpl);
return true;
} else if (QueueImpl->getCommandGraph() != nullptr) {
}
if (QueueImpl->getCommandGraph() != nullptr) {
throw sycl::exception(sycl::make_error_code(errc::invalid),
"end_recording called for a queue which is recording "
"to a different graph.");
Expand Down