Auto-resolve unresolved aliased fields

[zjbarg]

Adds simple default resolver to aliased fields when no resolver is present.

I'm not sure how to test this properly ( please comment )

#280

[zjbarg]

please consider adding a editorconfig file.

[mfn]

please consider adding a editorconfig file.

👍 added in b7ec923 !

[mfn]

Change LGTM too 👍

I'm not sure how to test this properly

Please allow me a bit time to figure this before merging, will get back ASAP!

[zjbarg]

Should we have a check that this new resolver only applies when there is a model defined?

[mfn]

Label as blocked until #289 can land, after which we can cover the change with a test

[mfn]

In #289 I've now added the test\Rebing\GraphQL\Tests\Database\SelectFieldsTest::testWithSelectFieldsAndModelAndAlias which I expect will "break" and needs to be adjusted after this PR.

[zjbarg]

Yup.

[mfn]

Thanks for the PR!

I've merged this into master and also the recent v1 branch and cut a new v1.22.0 release (hopefully it works 🤞 as expected).

Should we have a check that this new resolver only applies when there is a model defined?

There does not seem to be a technical reason for this yet.

For simple attribute aliases it seems the model is not required. Without it, the generated SQL query will simple not use qualified names. I.e. the difference will be:

• with model

  select "posts"."id", "posts"."title" from "posts" where "posts"."id" = ? limit 1;

• without model

  select "id", "title" from "posts" where "posts"."id" = ? limit 1;

But nevertheless it will work correctly; as the SelectFields in general does.

[zjbarg]

Thank you @mfn