Conversation
Collaborator
Guria
commented
Feb 15, 2026
Guria
commented
- Implemented setupHashUrl to switch urlAtom to hash-based routing, including hashToUrl and pathToHash helpers.
- Added tests and examples for setupHashUrl.
- Created setupStorybookUrl to configure urlAtom for Storybook, preventing History API sync and restoring original iframe URL.
- Included tests and examples for setupStorybookUrl.
- Updated registry.json to include new utilities and their metadata.
There was a problem hiding this comment.
Pull request overview
This PR adds two router utilities to configure urlAtom for different routing scenarios: setupHashUrl for hash-based routing and setupStorybookUrl for Storybook integration.
Changes:
- Added
setupHashUrlutility to enable hash-based routing (#/pathformat) with helper functionshashToUrlandpathToHash - Added
setupStorybookUrlutility to configureurlAtomfor Storybook by preventing History API sync and preserving iframe URL - Updated registry.json to include both utilities with their metadata
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/reusables/router/setup-hash-url/setup-hash-url.ts | Main implementation of hash-based routing with URL conversion helpers |
| src/reusables/router/setup-hash-url/setup-hash-url.meta.ts | Registry metadata for setupHashUrl utility |
| src/reusables/router/setup-hash-url/setup-hash-url.md | Documentation for setupHashUrl API and usage |
| src/reusables/router/setup-hash-url/setup-hash-url.example.ts | Example usage of setupHashUrl |
| src/reusables/router/setup-hash-url/setup-hash-url.browser.test.ts | Browser tests for setupHashUrl and helper functions |
| src/reusables/router/setup-storybook-url/setup-storybook-url.ts | Main implementation for Storybook URL configuration |
| src/reusables/router/setup-storybook-url/setup-storybook-url.meta.ts | Registry metadata for setupStorybookUrl utility |
| src/reusables/router/setup-storybook-url/setup-storybook-url.md | Documentation for setupStorybookUrl API and usage |
| src/reusables/router/setup-storybook-url/setup-storybook-url.example.ts | Example usage of setupStorybookUrl |
| src/reusables/router/setup-storybook-url/setup-storybook-url.browser.test.ts | Browser tests for setupStorybookUrl |
| registry.json | Updated registry with both new utilities and their file metadata |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/reusables/router/setup-storybook-url/setup-storybook-url.browser.test.ts
Outdated
Show resolved
Hide resolved
- Implemented setupHashUrl to switch urlAtom to hash-based routing, including hashToUrl and pathToHash helpers. - Added tests and examples for setupHashUrl. - Created setupStorybookUrl to configure urlAtom for Storybook, preventing History API sync and restoring original iframe URL. - Included tests and examples for setupStorybookUrl. - Updated registry.json to include new utilities and their metadata.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.