feat: support ppxlib with OCaml 5.2 AST #2835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/5.2
branch
from
a6222cc to
8840de1
Compare
Merged
anmonteiro
force-pushed
the
anmonteiro/5.2
branch
from
6328e7f to
a4526ec
Compare
davesnx
approved these changes
Mar 11, 2025
Member
davesnx
left a comment
davesnx
left a comment
There was a problem hiding this comment.
Hard to review the pprint_ast. Looks good, minor changes
Comment on lines
+2197
to
+2209
| let df_locallyAbstractFuncAnnotated | ||
| : 'figureMeOut = | ||
| (type a, type b) | ||
| : ( | ||
| (a, b) => | ||
| ( | ||
| inputEchoRecord(a), | ||
| inputEchoRecord(b), | ||
| ) | ||
| ) => | ||
| (input: a, input2: b) => ( | ||
| {inputIs: input}, | ||
| {inputIs: input2}, |
Member
Author
There was a problem hiding this comment.
I think it's a pretty big edge case-- no one really writes code like this.
I'm tempted to be reactive here since everything else looks pretty good.
Please feel free to report weird printing when you upgrade internally and I'd be happy to fix those cases.
Comment on lines
+325
to
+332
| let rec eval: type a. term(a) => a = x => | ||
| switch (x) { | ||
| | Int(n) => n | ||
| /* a = int */ | ||
| | Add => ((x, y) => x + y) | ||
| /* a = int => int => int */ | ||
| | App(f, x) => eval(f, eval(x)) | ||
| }; |
Member
There was a problem hiding this comment.
looks like an improvement, nice!
anmonteiro
force-pushed
the
anmonteiro/5.2
branch
from
f9b776b to
af1a3bf
Compare
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Apr 5, 2025
CHANGES: - require OCaml >= 4.08 (@anmonteiro, [reasonml/reason#2840](reasonml/reason#2840)) - support ppxlib with OCaml 5.2 AST (and require ppxlib >= 0.36) (@anmonteiro, [reasonml/reason#2835](reasonml/reason#2835))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2839