Fix record field and jsx props punned when with attributes #2824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro B S Lisboa <pedrobslisboa@gmail.com>
anmonteiro
reviewed
Jan 25, 2025
anmonteiro
reviewed
Jan 25, 2025
anmonteiro
reviewed
Jan 25, 2025
anmonteiro
reviewed
Jan 25, 2025
Member
anmonteiro
left a comment
anmonteiro
left a comment
There was a problem hiding this comment.
thanks for solving this one! almost there
pedrobslisboa
force-pushed
the
fix/record-attr
branch
3 times, most recently
from
faabffe to
ac648b7
Compare
Signed-off-by: Pedro B S Lisboa <pedrobslisboa@gmail.com>
pedrobslisboa
force-pushed
the
fix/record-attr
branch
from
ac648b7 to
235e9ea
Compare
Contributor
Author
Thanks for the review @anmonteiro |
anmonteiro
added a commit
that referenced
this pull request
Feb 2, 2025
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Feb 10, 2025
CHANGES: - rtop: read `~/.config/rtop/init.re` configuration file (@anmonteiro, [reasonml/reason#2813](reasonml/reason#2813)) - the `-init FILE` flag works as before - rtop: ignore `~/.ocamlinit.ml` or `~/.config/utop/init.ml` config files (@anmonteiro, [reasonml/reason#2813](reasonml/reason#2813)) - Add support for raw identifier syntax (@anmonteiro, [reasonml/reason#2796](reasonml/reason#2796)) - Fix: display attributes in record field and JSX props under punning (@pedrobslisboa, [reasonml/reason#2824](reasonml/reason#2824)) - Support modest Unicode letters in identifiers (@anmonteiro, [reasonml/reason#2828](reasonml/reason#2828)) - refmt: fix file descriptor leak (@anmonteiro, [reasonml/reason#2830](reasonml/reason#2830))
davesnx
added a commit
that referenced
this pull request
Dec 15, 2025
* 'master' of github.com:/reasonml/reason: add changelog for #2840 require OCaml 4.08 (#2840) update flakes parser: fix location in records (#2838) refactor: scopes in refmt command (#2836) chore(nix): remove flake-utils (#2832) ci: build 4.13.x (#2831) set version prep 3.15.0 test: reproduce fd leak (#2830) feat: modest support for unicode letters in identifiers (#2828) nix: remove nix-filter (#2827) nix: remove flake-utils (#2826) chore: update esy lock (#2825) chore: add changelog entry for #2824 Fix record field and jsx props punned when with attributes (#2824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2822
Description
This PR adds validation for records fields and jsx props to avoid pun them when the have attributes