Skip to content

Improve printing of destructuring with local open. #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anmonteiro merged 8 commits into from
Jul 28, 2024
Merged

Improve printing of destructuring with local open. #2684

anmonteiro merged 8 commits into from
Jul 28, 2024

Conversation

@SanderSpies
Copy link
Contributor

@SanderSpies SanderSpies commented Feb 24, 2023

Prints:

let EnterpriseContactForm.{
      personFirstNameField,
      personLastNameField,
      personEmailField,
      companyNameField,
      countryField,
      companySizeField,
      contactReasonField,
      submitFormState,
      onSubmit,
    } = formData;

as

let EnterpriseContactForm.{
 personFirstNameField,
 personLastNameField,
 personEmailField,
 companyNameField,
 countryField,
 companySizeField,
 contactReasonField,
 submitFormState,
 onSubmit,
} = formData;

instead.

See #2681.

SanderSpies and others added 8 commits February 24, 2023 19:01
@SanderSpies
Improve printing of destructuring with local open.
ab080d3
@SanderSpies
Add history.md entry.
60a3f17
@SanderSpies
Merge branch 'master' into sanderspies/fix_2681
14a92a9 
* master: (38 commits)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
  chore: update nix flake (reasonml#2692)
  chore(readme): clarify 3.9 is unreleased
  ...
@SanderSpies
add test
13004f2
@anmonteiro
Merge branch 'master' into sanderspies/fix_2681
288003d
@SanderSpies
Merge branch 'master' into sanderspies/fix_2681
5e5d22a
@anmonteiro
Merge remote-tracking branch 'origin/master' into sanderspies/fix_2681
1f0b757
@anmonteiro
fix extension case
62cd2a6
@anmonteiro anmonteiro merged commit 3cb2581 into reasonml:master Jul 28, 2024
@anmonteiro anmonteiro mentioned this pull request Jul 28, 2024
Closed
@anmonteiro anmonteiro mentioned this pull request Oct 21, 2024
Merged
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Oct 21, 2024
@anmonteiro
[new release] reason (2 packages) (3.13.0)
67adf6f 
CHANGES:

- Support `module%ppx` syntax (@anmonteiro,
  [reasonml/reason#2771](reasonml/reason#2771))
- Extend open to arbitrary module expression (@anmonteiro,
  [reasonml/reason#2773](reasonml/reason#2773))
- Wrap `let lazy patterns = ..` in parentheses (`let lazy(patterns) = ..`)
  (@anmonteiro, [reasonml/reason#2774](reasonml/reason#2774))
- Print poly variants as normal variansts (@sander Spies,
  [reasonml/reason#2708](reasonml/reason#2708))
- Improve printing of anonymous function return type (@sander Spies,
  [reasonml/reason#2686](reasonml/reason#2686))
- Improve printing of destructuring with local open (@sander Spies,
  [reasonml/reason#2684](reasonml/reason#2684)).
- Parse and print attributes in binding `let` ops (@anmonteiro,
  [reasonml/reason#2777](reasonml/reason#2777)).
- Parse polymorphic variants starting with `[|` (@anmonteiro,
  [reasonml/reason#2781](reasonml/reason#2781))
- Always add a line break in records with 2 or more fields (@anmonteiro,
  [reasonml/reason#2779](reasonml/reason#2779))
- Always break nonempty doc comments after `*/` (@anmonteiro,
  [reasonml/reason#2780](reasonml/reason#2780))
- Improve printing of arrows with labelled arguments (@anmonteiro,
  [reasonml/reason#2778](reasonml/reason#2778))
- Parse and print extensions in `open%foo` expressions and structure items
  (@anmonteiro, [reasonml/reason#2784](reasonml/reason#2784))
- Add support for module type substitutions
  (@anmonteiro, [reasonml/reason#2785](reasonml/reason#2785))
- Support `type%foo` extension sugar syntax (@anmonteiro,
  [reasonml/reason#2790](reasonml/reason#2790))
- Support quoted extensions (@anmonteiro,
  [reasonml/reason#2794](reasonml/reason#2794))
- Parse universal type variables in signature items (@anmonteiro,
  [reasonml/reason#2797](reasonml/reason#2797))
- Fix formatting of callbacks with sequence expressions (@anmonteiro,
  [reasonml/reason#2799](reasonml/reason#2799))
- Fix printing of attributes on module expressions (@anmonteiro,
  [reasonml/reason#2803](reasonml/reason#2803))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SanderSpies @anmonteiro