Skip to content

support jsx transform with fragment#835

Merged
anmonteiro merged 5 commits into
reasonml:mainfrom
tatchi:use-jsx-for-fragment
Jun 4, 2024
Merged

support jsx transform with fragment#835
anmonteiro merged 5 commits into
reasonml:mainfrom
tatchi:use-jsx-for-fragment

Conversation

@tatchi

@tatchi tatchi commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

This is my attempt at fixing #834

@anmonteiro anmonteiro force-pushed the use-jsx-for-fragment branch from 7ff41bb to bd80320 Compare June 4, 2024 01:00
@anmonteiro

Copy link
Copy Markdown
Member

Thank you! This is a great catch.

I was wondering whether < key=... > </> was possible but it looks like it isn't: https://react.dev/reference/react/Fragment#caveats

@anmonteiro

Copy link
Copy Markdown
Member

I fixed the transformation. in the jsx runtime, children need to be passed in the props object as {children: ...}

@anmonteiro anmonteiro merged commit fc156dd into reasonml:main Jun 4, 2024
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Jun 4, 2024
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants