Skip to content

feat: reduce too many exposes module in toplevel #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r17x wants to merge 3 commits into from
Closed

feat: reduce too many exposes module in toplevel #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a84a100
feat: reduce too many exposes module in toplevel
r17x Sep 6, 2023
0b41088
chore: set wrapped true in dune
r17x Sep 7, 2023
12ba268
Merge branch 'main' into feat/reduce-too-many-toplevel-module
r17x Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/React.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,3 +558,12 @@ external setDisplayName: (component('props), string) => unit = "displayName";

[@mel.get] [@mel.return nullable]
external displayName: component('props) => option(string) = "displayName";

module DOM = ReactDOM
module DOMServer = ReactDOMServer
module DOMStyle = ReactDOMStyle
module ErrorBoundary = ReasonReactErrorBoundary
module Event = ReactEvent
module TestRenderer = ReactTestRenderer
module TestUtils = ReactTestUtils
module Router = ReasonReactRouter
2 changes: 1 addition & 1 deletion src/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
(public_name reason-react)
(preprocess
(pps melange.ppx reason-react-ppx))
(wrapped false)
(wrapped true)

@r17x r17x Sep 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been changes to be true @davesnx . I think is incomplete yet? could you give me suggestions for this changes?

@anmonteiro anmonteiro Sep 10, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One way to move forward with this would be to fix the build

(libraries melange.dom)
(modes melange))