-
Notifications
You must be signed in to change notification settings - Fork 349
Add React 18 bindings #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4828ec6
Add bindings
davesnx 8ab323d
Fix tests with React 18
davesnx 558a060
Add deprecation note into ReactDOM.render
davesnx eea6707
Add deprecation note into ReactDOM.hydrate
davesnx e87636f
Fix React__test
davesnx a07f4ac
Export make for errorbound
davesnx 3a5d7e4
Split useSyncExternalStore
davesnx f093767
Move useDebugValue inside hooks
davesnx 6c8b3f7
Move use into Experimental
davesnx 2371d5c
Format Jest
davesnx 5d5e3be
Add uncurried to callback and test hook
davesnx f20786c
Rename React.DOM test title
davesnx 41129c3
Remove unnecessary uncurry
davesnx d5bfd89
Hide error on jest tests
davesnx 5056a42
Add jest stuff
davesnx 49a8ccb
Rename useSyncExternalStoreWithServer
davesnx 0e5ab99
Move all hook based tests into Hooks__test
davesnx 3451140
Remove Obj.magic in favor of Js.t
davesnx 569e5a0
Move comment into the right place
davesnx b79f6b0
Build @all instead of @@default
davesnx cef6462
Merge branch 'main' into react-18
davesnx f70bf6c
Update src/React.rei
davesnx 48456c6
Update src/React.rei
davesnx 2058e76
Update src/React.rei
davesnx e76eba2
Update src/hooks.re
davesnx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also include SuspenseList in this module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SuspenseList got unstable by React in facebook/react#27061 and facebook/react#27056 (comment)
I'm fine keeping it but it's very useless