Wrap the React Library

[anmonteiro]

reason-react exposes too many toplevel modules. These could be nested under React, e.g.:

• React.DOM
• React.ErrorBoundary
• React.DOMServer
  etc

[davesnx]

I would like to rethink this and keep the toplevel equal to the library names:

• "react" -> React.re
• "react-dom" -> ReactDOM.re
• "react-dom/test-utils" -> ReactDOM.TestUtils (current library is called "reason-react.test" and expose Renderer and Utils
• "react-test-renderer" -> "ReactTestRenderer.re"
• "react-dom/server" -> ReactDOM.Server
• reason-react's router -> "ReasonReactRouter" (or SimpleRouter) currently called React.Router (This isn't related with the toplevel, but rather showcase that isn't part of React)

We could unwrap and keep the minimum toplevels but those match the packages installed from npm 1 to 1.

The benefits of this are:

• Documentation to live close to the modules
• Have 1 to 1 bindings with npm packages
• Clear separation what's part of react, and what's not (react-dom stuff, react testing stuff, etc)
• So reason-react-native lives on ReactNative, and not React.Native

[anmonteiro]

I don't think that's a good idea. Why is it so important that our library structure matches the JS package names / sub-paths?

I actually think that the current wrapped design is quite elegant and there's a nice sub-module for everything that you can access.

[davesnx]

I don't think that's a good idea. Why is it so important that our library structure matches the JS package names / sub-paths?

First for discoverability and second to have the minimum amount of subjectivity on the names of the structure. People don't read the documentation to use a module/function, they often use autocomplete.

[anmonteiro]

I don't think it's very discoverable having to add (libraries react react.dom react.dom-server) in order to have those modules appear in your editor. It's a much better API to have (libraries reason-react) and React.DOM etc. don't you think?

[davesnx]

What I'm proposing is to have libraries reason-react which exposes react, reactdom, etc. and not fall into the trap what we had before so, React.Event, ReactDOM.Style, ReactDOM.Server etc still remains wrapped.

[anmonteiro]

how do you expose those multiple toplevel modules from:

1. a single library reason-react
2. without exposing all?

[davesnx]

wrapped false, one module per toplevel, the rest either inlined or private libraries

[anmonteiro]

That actually sounds pretty nice if you can make it work. I'm in favor of it, if we can manage to hide the internal modules.