Repository navigation
Conversation
Adds uncancelable wrapper to evaluation of resource so that cancelation can only occur at reasonable points.
- polling the entire brackFull unmasks the rest of the evaluation. Instead we have to just mask the acquire and use - in allocatedCase, insert cancelation boundary before checking the next frame instead of unmasking the rest of the evaluation
in Resource, combineK has a bespoke implementation which propagates the final exit case to both inner resource finalizers, while orElse is derived from handleErrorWith, which does not propagate the final exit case, so it's not surprising that the test that it is equivalent to combineK would fail. Removing this test.
reardonj
force-pushed
the
4627-eval-cancelation
branch
2 times, most recently
from
August 29, 2026 13:18
93d45a0 to
3af09e6
Compare
Author
|
Superseded, you already took the fix and the rebase means this branch would drag the old commits back. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code you asked for. FoldProbeSuite prints the four shapes, including where ctr comes from. ComboProbeSuite is the deleted property with the failing seed pinned, so it falsifies at 152.
Run with: sbt "testsJVM/testOnly cats.effect.FoldProbeSuite cats.effect.ComboProbeSuite"
Not meant to merge, just easier to read as a diff.