Skip to content

fix: type and lint errors#793

Merged
kurtdoherty merged 1 commit intomainfrom
fix-type-lint-errors
Sep 17, 2025
Merged

fix: type and lint errors#793
kurtdoherty merged 1 commit intomainfrom
fix-type-lint-errors

Conversation

@kurtdoherty
Copy link
Contributor

CI has not been correctly report TS or lint errors during the yarn check stage. This will be looked at separately, but this PR resolves all type and lint errors.

@kurtdoherty kurtdoherty marked this pull request as ready for review September 17, 2025 00:46
@rpt-uk-github
Copy link

rpt-uk-github commented Sep 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 89431621 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8943162) Report Missing Report Missing Report Missing
Head commit (0c92c3a) 9325 8622 92.46%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#793) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

name: Test
runs-on: ubuntu-latest
steps:
- uses: seferov/pr-lint-action@master
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: scout to ensure we're pinned to a specific version

@kurtdoherty kurtdoherty merged commit 9c0c614 into main Sep 17, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the fix-type-lint-errors branch September 17, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants