Skip to content

chore: standardise context objects pattern#777

Merged
kurtdoherty merged 3 commits intomainfrom
chore-standardise-context-objects-and-replace-dialog-ref
Sep 12, 2025
Merged

chore: standardise context objects pattern#777
kurtdoherty merged 3 commits intomainfrom
chore-standardise-context-objects-and-replace-dialog-ref

Conversation

@kurtdoherty
Copy link
Contributor

This PR

  • Adds new guidelines doc for context objects
  • Replaces dialogRef for Drawer and Dialog context objects with simple getClosestDialogElement helper function

@kurtdoherty kurtdoherty marked this pull request as ready for review September 12, 2025 01:09
@rpt-uk-github
Copy link

rpt-uk-github commented Sep 12, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 47bd94a1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (47bd94a) Report Missing Report Missing Report Missing
Head commit (81d20ef) 9260 8566 92.51%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#777) 40 40 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit 0032896 into main Sep 12, 2025
5 of 6 checks passed
@kurtdoherty kurtdoherty deleted the chore-standardise-context-objects-and-replace-dialog-ref branch September 12, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants