Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
This PR
ChipSelectChipcomponent. This is effectively a styled checkbox. When more than one are used together with the same name and in the same form, they work as a checkbox group.note: checkbox inputs were used over radio button because it was non-trivial to implement the required toggling functionality (clicking a chip will check OR uncheck it) on top of radio buttons. This is because radio buttons are not designed to be unchecked when clicked on. Further, radio button groups include special keyboard navigation handling that causes the checked radio to change as the options are navigated using arrow keys; this would only be appropriate in the single-selection context of the chip select. In the end, checkboxes seemed the better fit, with single-selection behaviour being the only "custom" behaviour we need to model.