Skip to content

feat: add SelectNative#756

Merged
kurtdoherty merged 1 commit intomainfrom
feat-add-native-select
Sep 5, 2025
Merged

feat: add SelectNative#756
kurtdoherty merged 1 commit intomainfrom
feat-add-native-select

Conversation

@kurtdoherty
Copy link
Contributor

Context

  • Form controls are foundational to any product, so it's important we provide implementations of the form controls in the Design System.
  • Native components are low-hanging fruit, so we're starting with them.

This PR

  • Adds new SelectNative component. It's largely identical to the CompactSelectNative component already available in Elements, only this one has styles for when the form control is validated as part of a form and its value is determined to be invalid. Importantly, error styles are only applied when the form control is marked as "touched."
Screenshot 2025-09-05 at 5 21 01 pm Screenshot 2025-09-05 at 5 21 09 pm Screenshot 2025-09-05 at 5 21 16 pm Screenshot 2025-09-05 at 5 21 22 pm Screenshot 2025-09-05 at 5 21 27 pm

@rpt-uk-github
Copy link

rpt-uk-github commented Sep 5, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty marked this pull request as ready for review September 5, 2025 07:26
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 96ec3c81 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (96ec3c8) Report Missing Report Missing Report Missing
Head commit (abd58fc) 9080 8392 92.42%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#756) 30 30 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit e0c2a49 into main Sep 5, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-add-native-select branch September 5, 2025 07:35
@kurtdoherty kurtdoherty linked an issue Sep 9, 2025 that may be closed by this pull request
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v5 component refactor: Select

2 participants