Skip to content

feat: add Input with support for type='checkbox'#737

Merged
kurtdoherty merged 1 commit intomainfrom
feat-add-input-checkbox
Sep 1, 2025
Merged

feat: add Input with support for type='checkbox'#737
kurtdoherty merged 1 commit intomainfrom
feat-add-input-checkbox

Conversation

@kurtdoherty
Copy link
Contributor

Context

  • We're delivering new core table components and we require a checkbox component to enable row selection.
  • The existing Checkbox component includes a lot of functionality that is simply irrelevant to row selection (such as visual labels and supplementary information).
  • Ideally, we want a thin wrapper around an <input type="checkbox"> so that we have the correct checkbox visual appearance, without any of the additional label handling. That way, this low-level input component can be used internally by Checkbox and our row selection table component.

This PR

  • Adds a new Input component with support for type="checkbox". This component will be expanded to support other input types and represents the lowest-level styled input component in Elements.
Screenshot 2025-09-02 at 7 39 13 am Screenshot 2025-09-02 at 7 39 22 am

@rpt-uk-github
Copy link

rpt-uk-github commented Sep 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty marked this pull request as ready for review September 1, 2025 21:39
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 885de7a1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (885de7a) Report Missing Report Missing Report Missing
Head commit (5c84210) 8660 8021 92.62%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#737) 24 24 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit 44318b2 into main Sep 1, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-add-input-checkbox branch September 1, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants