Skip to content

fix: Table.HeaderCell renders as a td when it has no cell content#735

Merged
kurtdoherty merged 1 commit intomainfrom
fix-table-header-cell-empty-content-handling
Sep 1, 2025
Merged

fix: Table.HeaderCell renders as a td when it has no cell content#735
kurtdoherty merged 1 commit intomainfrom
fix-table-header-cell-empty-content-handling

Conversation

@kurtdoherty
Copy link
Contributor

What it says on the tin.

Header cells are not permitted to have empty content: https://dequeuniversity.com/rules/axe/4.8/empty-table-header?application=axeAPI

@rpt-uk-github
Copy link

rpt-uk-github commented Sep 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty marked this pull request as ready for review September 1, 2025 03:23
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 23987571 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2398757) Report Missing Report Missing Report Missing
Head commit (abbec7a) 8636 7997 92.60%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#735) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit 885de7a into main Sep 1, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the fix-table-header-cell-empty-content-handling branch September 1, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants