Skip to content

feat: SupplementaryInfo supports inherit colour#702

Merged
kurtdoherty merged 1 commit intomainfrom
feat-supplementary-info-inherit-colour
Aug 21, 2025
Merged

feat: SupplementaryInfo supports inherit colour#702
kurtdoherty merged 1 commit intomainfrom
feat-supplementary-info-inherit-colour

Conversation

@kurtdoherty
Copy link
Contributor

This PR

  • Adds new colour prop to SupplementaryInfo that supports all the same colours as SupplementaryInfo.Item. This prop allows the colour of all items to be set, while still permitting individual items to be uniquely coloured via their own colour prop.
  • Adds a new inherit colour value that causes the parent's colour to be inherited. This is useful when the supplementary info is being displayed in a parent that wants to control the default colour of items.
  • Makes inherit the new default for both the SupplementaryInfo and SupplementaryInfo.Item components.
  • Small scout to use one custom SVG for the separator dot instead of three.
Screenshot 2025-08-22 at 8 32 01 am

@rpt-uk-github
Copy link

rpt-uk-github commented Aug 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@kurtdoherty kurtdoherty marked this pull request as ready for review August 21, 2025 22:33
@kurtdoherty kurtdoherty force-pushed the feat-supplementary-info-inherit-colour branch from 3ba8fc4 to 4abeac5 Compare August 21, 2025 22:37
@kurtdoherty kurtdoherty force-pushed the feat-supplementary-info-inherit-colour branch from 4abeac5 to 9d8d36b Compare August 21, 2025 22:40
@codacy-production
Copy link

codacy-production bot commented Aug 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e1c0d061 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e1c0d06) Report Missing Report Missing Report Missing
Head commit (9d8d36b) 8264 7627 92.29%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#702) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit a7f7025 into main Aug 21, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the feat-supplementary-info-inherit-colour branch August 21, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants