Skip to content

chore: refactor EmptyData#697

Merged
kurtdoherty merged 2 commits intomainfrom
chore-refactor-empty-data
Aug 20, 2025
Merged

chore: refactor EmptyData#697
kurtdoherty merged 2 commits intomainfrom
chore-refactor-empty-data

Conversation

@kurtdoherty
Copy link
Contributor

@kurtdoherty kurtdoherty commented Aug 20, 2025

This PR

  • Refactors EmptyData to align with latest patterns/conventions
  • Adds height prop to all a fixed height to be specified.
  • Removes EmptyData.SecondaryDesciption in favour of new secondaryText prop on EmptyData.Description
  • Updates EmptyData.Description to render the title as a h3 element.
  • Adds new EmptyData.Action for anchor-based actions. It's based on Button.
  • Updates EmptyData.ActionButton to be best on Button too.
  • Scouts an update to our design tokens to match latest changes in Figma.
Screenshot 2025-08-20 at 11 25 07 am Screenshot 2025-08-20 at 11 25 12 am Screenshot 2025-08-20 at 11 25 19 am

@kurtdoherty kurtdoherty marked this pull request as ready for review August 20, 2025 01:27
@rpt-uk-github
Copy link

rpt-uk-github commented Aug 20, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@github-actions github-actions bot closed this Aug 20, 2025
github-actions[bot]

This comment was marked as resolved.

@kurtdoherty kurtdoherty reopened this Aug 20, 2025
@kurtdoherty kurtdoherty changed the title chore!: refactor EmptyData chore: refactor EmptyData Aug 20, 2025
@kurtdoherty kurtdoherty force-pushed the chore-refactor-empty-data branch from 5eebbca to cfaf1ec Compare August 20, 2025 01:30
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 502e00a1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (502e00a) Report Missing Report Missing Report Missing
Head commit (cfaf1ec) 8248 7611 92.28%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#697) 34 34 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kurtdoherty kurtdoherty merged commit 724db3c into main Aug 20, 2025
6 checks passed
@kurtdoherty kurtdoherty deleted the chore-refactor-empty-data branch August 20, 2025 01:49
@kurtdoherty kurtdoherty mentioned this pull request Sep 10, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants