Skip to content

fix: TopBar secondary nav regression introduced by #687#690

Merged
kurtdoherty merged 1 commit intomainfrom
fix-top-bar-regression
Aug 18, 2025
Merged

fix: TopBar secondary nav regression introduced by #687#690
kurtdoherty merged 1 commit intomainfrom
fix-top-bar-regression

Conversation

@kurtdoherty
Copy link
Contributor

What it says on the tin.

#687 introduced a regression w.r.t. the top bar's secondary nav responsive styles. This PR fixes that regression.

@rpt-uk-github
Copy link

rpt-uk-github commented Aug 18, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8075ee61 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8075ee6) Report Missing Report Missing Report Missing
Head commit (5af053d) 8226 7589 92.26%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#690) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@@ -89,7 +89,7 @@ export const ElTopBarSecondaryNavContainer = styled.div`

display: none;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurtdoherty kurtdoherty marked this pull request as ready for review August 18, 2025 08:16
@kurtdoherty kurtdoherty merged commit ddfd660 into main Aug 18, 2025
5 of 6 checks passed
@kurtdoherty kurtdoherty deleted the fix-top-bar-regression branch August 18, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants