feat(dask): detect and create Rucio resources for Dask cluster #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Feb 11, 2025
…hub#634) We detect if rucio is necessary for Dask cluster by checking top level rucio statement under resources field in reana.yaml. Closes reanahub/reana#873
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #634 +/- ##
==========================================
- Coverage 73.46% 73.16% -0.31%
==========================================
Files 17 17
Lines 1975 1986 +11
==========================================
+ Hits 1451 1453 +2
- Misses 524 533 +9
|
Alputer
added a commit
to Alputer/reana-workflow-controller
that referenced
this pull request
Feb 11, 2025
…hub#634) We detect if Rucio is necessary for Dask cluster by checking top level rucio statement under resources field in reana.yaml. Closes reanahub/reana#873
Alputer
changed the title
We detect if Rucio is necessary for Dask cluster by checking top level rucio statement under resources field in reana.yaml. Some amendments were needed in order to fetch the secrets from secrets store instead of environment variables since workflow controller does not have access to runtime environment variables just like job controller. Closes reanahub/reana#873
tiborsimko
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We detect if Rucio is necessary for Dask cluster by checking top level rucio statement under resources field in reana.yaml. Some amendments were needed in order to fetch the secrets from secrets store instead of environment variables since workflow controller does not have access to runtime environment variables just like job controller.
Closes reanahub/reana#873