Conversation
….json so release PRs require review
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the release workflow from a single-step publish process to a two-step process requiring an explicit release PR that must be reviewed and merged before publishing. The changes improve robustness by removing dependency on personal access tokens and adding safety through mandatory code owner reviews.
- Creates a new "Prepare Release PR" workflow that handles version bumping and PR creation
- Modifies the publish workflow to trigger only on merged release PRs or manual reruns
- Adds CODEOWNERS file requiring frontend team review for config file changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/publish.yml | Refactored to trigger on release PR merges instead of manual dispatch with version selection |
| .github/workflows/create-release.yml | New workflow for creating release PRs with version bumping and tagging |
| .github/CODEOWNERS | Added to require frontend team review for GitHub config and package changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bradsmith712
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DAISY-9079
Description
The last attempt at a publish workflow required a GitHub personal access token (PAT) to be setup in order to get around the requirement that only approved PRs can be merged to the
mainbranch. PATs have to be renewed every year, and are tied to a specific user. We want the workflow to be more robust than that, and also prefer a workflow with a release PR that can be reviewed before it's released for added safety. This PR also adds a requirement that frontend codeowners review any PRs with changes to config files, including package.json so that codeowner reviews are required for release PRs.The new process is as follows:
@realtimemd/react-time-picker.Suggested QA testing
N/A - We won't be able to test this again until it's merged to the
mainbranch, because the new "Prepare Release PR" workflow doesn't exist there yet. There may have to be followup PRs to fix any issues.