Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github Atom to env.rst #473

Merged
merged 1 commit into from
Aug 29, 2014
Merged

Conversation

syndbg
Copy link
Contributor

@syndbg syndbg commented Aug 29, 2014

Also small PEP8 fixes by flake8.

Unrelated to pull request: We should also add/discuss some rules about new lines between headings.
The style guide is pretty descriptive, but it doesn't touch this subject, which results into many files with varying number of new lines between headings.

My suggestions are:

  • Chapter and page title remain unchanged
  • Section and sub section should have 2 new lines for extra readibility

Atom
----

`Github Atom <https://atom.io/>`_ is a hackable text editor for the 21st century,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool is simply named Atom. Perhaps you meant to say

GitHub's `Atom <https://atom.io/>`_ ...

If that isn't what you meant, please change this to just be Atom.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and you're right, I should keep it with the same name.

@sigmavirus24
Copy link
Contributor

@syndbg please open up a separate (meta-) issue about the spacing between headings. It would be better to discuss those ideas somewhere else.

sigmavirus24 added a commit that referenced this pull request Aug 29, 2014
Added Github Atom to env.rst
@sigmavirus24 sigmavirus24 merged commit 7f29f05 into realpython:master Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants