Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary email converter #137

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Remove unnecessary email converter #137

merged 1 commit into from
Jul 13, 2020

Conversation

bryanwweber
Copy link
Contributor

The homework and exam grades don't have an Email Address column, so the
converter isn't necessary

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

From a comment on the article, the "Email Address" converter for the hw_exam_grades.csv file is not needed and potentially confusing.

The homework and exam grades don't have an Email Address column, so the
converter isn't necessary
Copy link
Contributor

@somacdivad somacdivad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @bryanwweber 👍

I'll go ahead and merge.

@somacdivad somacdivad merged commit 8d25279 into master Jul 13, 2020
@somacdivad somacdivad deleted the fix-gradebook branch July 13, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants