Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2861: Deprecate AppConfiguration.app and add app instance to App Provider #6788

Merged
merged 11 commits into from
Jul 16, 2024

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Jul 11, 2024

@realm/devdocs

What, How & Why?

Allow the client to use an existing Realm.App in @realm/react. Helps support usecases like #6233 better.

This closes #6785

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • 📦 Updated internal package version in consuming package.jsons (if updating internal packages)
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary
  • 🔔 Mention @realm/devdocs if documentation changes are needed

@gagik gagik marked this pull request as ready for review July 15, 2024 14:21
@gagik gagik requested review from kneth and kraenhansen July 15, 2024 14:21
@gagik gagik changed the title RJS-2861: Add app instance to App Provider RJS-2861: Deprecate AppConfigurationa.app and add app instance to App Provider Jul 15, 2024
@gagik gagik changed the title RJS-2861: Deprecate AppConfigurationa.app and add app instance to App Provider RJS-2861: Deprecate AppConfiguration.app and add app instance to App Provider Jul 15, 2024
gagik and others added 2 commits July 16, 2024 10:27
Co-authored-by: Kræn Hansen <kraen.hansen@mongodb.com>
@gagik gagik merged commit adda258 into main Jul 16, 2024
23 checks passed
@gagik gagik deleted the gagik/add-app-instance-to-app-provider branch July 16, 2024 12:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@realm/react: Passing an app as a prop to AppProvider
3 participants