Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJS-2846: Fix path configuration when using sync #6753

Merged
merged 12 commits into from
Jun 25, 2024
Merged

Conversation

gagik
Copy link
Contributor

@gagik gagik commented Jun 24, 2024

What, How & Why?

A bug was introduced in 12.8.0 where a custom path was being ignored when using a sync configuration. This fixes it and introduces a new test to track it.

This closes #6754

☑️ ToDos

  • 📝 Changelog entry
  • [X]~ 📝 Compatibility label is updated or copied from previous entry~
  • 📝 Update COMPATIBILITY.md
  • 🚦 Tests
  • [ ]~ 📦 Updated internal package version in consuming package.jsons (if updating internal packages)~
  • 📱 Check the React Native/other sample apps work if necessary
  • 💥 Breaking label has been applied or is not necessary

@cla-bot cla-bot bot added the cla: yes label Jun 24, 2024
@gagik gagik changed the title Fix sync path RJS-2846: Fix sync path Jun 24, 2024
@gagik gagik marked this pull request as ready for review June 24, 2024 16:09
@gagik gagik changed the title RJS-2846: Fix sync path RJS-2846: Fix path configuration when using sync Jun 24, 2024
Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

integration-tests/tests/src/tests/sync/flexible.ts Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/flexible.ts Outdated Show resolved Hide resolved
integration-tests/tests/src/tests/sync/flexible.ts Outdated Show resolved Hide resolved
gagik and others added 3 commits June 25, 2024 08:47
@gagik gagik merged commit 65af392 into main Jun 25, 2024
34 checks passed
@gagik gagik deleted the gagik/fix-sync-path branch June 25, 2024 11:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom paths do not work when using sync
4 participants