Change RealmReact to be a dynamic framework #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It embeds RealmJS and GCDWebServers frameworks. This fixes #58, where there were issues with building for devices rather than just the simulator. Some changes were made so that RealmReact.m didn't need to be weakly linked to libReact.a since that would actually cause any executable that uses this framework from being able to compile with bitcode.
| @@ -77,22 +87,26 @@ -(void)setBridge:(RCTBridge *)bridge { | |||
| } | |||
|
|
|||
| [contextExecutor executeBlockOnJavaScriptQueue:^{ | |||
| RCTJavaScriptContext *rctJSContext = object_getIvar(contextExecutor, contextIvar); | |||
There was a problem hiding this comment.
Because I wanted to avoid weak linking libReact.a, which would mean nobody could build with bitcode using this framework. Strongly linking libReact.a wouldn't really work either.
|
👍 errors are with CI |
alazier
pushed a commit
that referenced
this pull request
May 23, 2016
Add fine-grained notification stuff
alazier
pushed a commit
that referenced
this pull request
Sep 14, 2016
Release 0.14.0-5 with sync 0.26.3
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It embeds RealmJS and GCDWebServers frameworks. This fixes #58, where there were issues with building for devices rather than just the simulator.
Some changes were made so that RealmReact.m didn't need to be weakly linked to libReact.a since that would actually cause any executable that uses this framework from being able to compile with bitcode.