First pass at object_store refactor #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,60 +24,32 @@ | |||
| using RJSAccessor = realm::NativeAccessor<JSValueRef, JSContextRef>; | |||
| using namespace realm; | |||
|
|
|||
| size_t ObjectArray::size() { | |||
| return link_view->size(); | |||
| static inline List * RJSVerifiedArray(JSObjectRef object) { | |||
There was a problem hiding this comment.
This probably should be RJSVerifiedList now
|
Looks good (except CI build issue) 👍 |
alazier
added a commit
that referenced
this pull request
Oct 14, 2015
First pass at object_store refactor
appden
pushed a commit
that referenced
this pull request
Apr 22, 2016
Latest fixes for react-native/android
alazier
pushed a commit
that referenced
this pull request
Sep 14, 2016
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@appden
Want to get the renaming out of the way before making the rest of the changes.