Add _updateSchema functionality #5003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
Oct 11, 2022
| @@ -667,6 +667,8 @@ classes: | |||
| read_group: () -> Group& | |||
| duplicate: () -> TransactionRef | |||
|
|
|||
| update_schema: '(schema: std::vector<ObjectSchema>, version: uint64_t, migration_function: Nullable<std::function<(old_realm: SharedRealm, new_realm: SharedRealm, new_schema_handle: Schema&) -> void>>, initialization_function: Nullable<std::function<(realm: SharedRealm) -> void>>, in_transaction: bool) -> void' | |||
There was a problem hiding this comment.
considering this is just being set to null, could I set those functions to just be regular Nullable<() -> void> arguments?
There was a problem hiding this comment.
I don't think the generated C++ would like that .. cc @RedBeard0531?
There was a problem hiding this comment.
I played around with this just now and it does seem like this would not work. So I will just leave it this way, if this ends up being jarring we could introduce type aliases but it's not that much longer than other functions like this.
gagik
force-pushed
the
gagik/updateschema
branch
from
9f0b01b to
4dd4f37
Compare
kraenhansen
approved these changes
Oct 12, 2022
gagik
force-pushed
the
gagik/updateschema
branch
from
4dd4f37 to
4bcb942
Compare
kraenhansen
pushed a commit
that referenced
this pull request
Oct 24, 2022
kraenhansen
pushed a commit
that referenced
this pull request
Oct 26, 2022
RedBeard0531
pushed a commit
that referenced
this pull request
Nov 15, 2022
RedBeard0531
pushed a commit
that referenced
this pull request
Nov 23, 2022
takameyer
pushed a commit
that referenced
this pull request
Dec 28, 2022
kraenhansen
pushed a commit
that referenced
this pull request
Mar 1, 2023
kraenhansen
pushed a commit
that referenced
this pull request
Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Add the ability to update schema to the bindgen repository.
This closes #4959
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryCOMPATIBILITY.mdpackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: