Fix types for Object Listener #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Feb 11, 2022
| @@ -1,3 +1,4 @@ | |||
| c76131748cbb048e78a987eb234d8a9609e26430 | |||
| f38d8cf7cac992767a451d2f3cf3310e3546bf6f | |||
| fa80f12bf3fbfe1337ae69e12c59051fac347001 | |||
| 99e64a8e990d2579bcfe382f755edbc61f70af4e | |||
There was a problem hiding this comment.
Yes...the types document still had our merge commit from version 10.5.0
There was a problem hiding this comment.
Somehow that seems to exist across multiple SHAs.
kraenhansen
approved these changes
Feb 11, 2022
takameyer
force-pushed
the
andrew/object-listener-type
branch
2 times, most recently
from
bb49df8 to
d7cffb9
Compare
When a class extends Realm.Object, adding a listener to an instance of the object would not correctly type the object returned in the callback. With this change, the callback returns an object of the same type as the instance it was called from.
takameyer
force-pushed
the
andrew/object-listener-type
branch
from
d7cffb9 to
3d26608
Compare
tomduncalf
reviewed
Feb 11, 2022
| @@ -251,16 +251,16 @@ declare namespace Realm { | |||
| /** | |||
| * @returns void | |||
| */ | |||
| addListener(callback: ObjectChangeCallback): void; | |||
| addListener(callback: ObjectChangeCallback<this>): void; | |||
takameyer
added a commit
that referenced
this pull request
Feb 14, 2022
When a class extends Realm.Object, adding a listener to an instance of the object would not correctly type the object returned in the callback. With this change, the callback returns an object of the same type as the instance it was called from.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a class extends Realm.Object, adding a listener to an instance of the
object would not correctly type the object returned in the callback.
With this change, the callback returns an object of the same type as the
instance it was called from.
This closes #4337
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: