Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10] RN debugger fixes #3368

Closed
wants to merge 4 commits into from
Closed

[v10] RN debugger fixes #3368

wants to merge 4 commits into from

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Oct 29, 2020

What, How & Why?

This closes #3358 and #3361

  • Establish session between Chrome debugger and RPC server on device
  • Create Realm.App instance on device and proxy object in Chrome debugger

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@kneth kneth self-assigned this Oct 29, 2020
@Anzormumladze
Copy link

we are waiting for your fixes as soon as possible

Copy link

@Muzzamil75 Muzzamil75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LEt it merge

@Anzormumladze
Copy link

What, How & Why?

This closes #3358 and #3361

  • Establish session between Chrome debugger and RPC server on device
  • Create Realm.App instance on device and proxy object in Chrome debugger

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

can you tell how much time you need to finish this bug fix?

@kraenhansen
Copy link
Member

Closing this in favour of #3411

@kneth kneth deleted the kneth/rn-create-session branch February 1, 2021 15:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling React Native Debug mode causes Error: Must first create RPC session with a valid host from rpc.js:314
4 participants