-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use device IP addresses to connect to RPC host #292
Conversation
56285d3
to
00b19d9
Compare
@alazier will you take a look at this |
FWIW, I'm blocked by #284 trying to evaluate realm-js for our needs. In my case, I've only tried to run in the iOS Simulator so far. I decided to give this branch a spin to provide feedback, but it's dying in the simulator at index.js:29. Screencap: This is the first time I've tried to build Realm from source, and this smells like a build process issue rather than a code issue? My local Realm build setup sequence follows: Following the instructions at Building Realm, I built the RealmReact target in a clone checked out to this branch. I modified my app's
Next, I ran Offhand, it's not apparent what I may have missed, but the bit where Pointers (and perhaps improved setup docs for outside contributors...) would be greatly appreciated. |
@jwhitley thanks for the detailed report! Can you confirm that the |
@appden, thanks, reviewing those settings fixed it. I got lazy, only lightly skimmed the getting started steps, due to a bad assumption that rnpm had set me up correctly. (Only because it's done the right thing infallibly every other time I've used it...) So far, so good with this branch on the iOS Simulator. I'll have a go with a development device tomorrow and report back. |
} | ||
|
||
// Log the original exception for debugging purposes. | ||
console.error(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only logs the error of the last failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the point since it's almost always going to try multiple IP addresses, so we'd just be spamming the console if we logged every error.
Use device IP addresses to connect to RPC host
@appden Sorry for the late response, but this change as merged on |
@jwhitley thanks for the update! I'd really appreciate you trying to use version |
Eh, now 10.0.0-rc.2 this problem is still not resolved |
It still only tries localhost for the simulator, but for devices, we now get a list of possible IP addresses to attempt to connect to before throw a more helpful exception.
Resolves #284 and fixes #276