Support RectNative version 0.14 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we are going to just drop support for 0.13.x, then the ReactExample package.json needs to be changed as well. 😄 |
| JSGlobalContextRef ctx = JSGlobalContextCreate(NULL); | ||
| rctJSContext = [[RCTJavaScriptContext alloc] initWithJSContext:ctx]; | ||
| JSContext *context = [[JSContext alloc] init]; | ||
| //JSGlobalContextRef ctx = JSGlobalContextCreate(NULL); |
|
Changes look good. We should add a comment explaining the method signature stuff though. |
alazier
added a commit
that referenced
this pull request
Nov 13, 2015
Support RectNative version 0.14
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument type for ReactNatives JSContext initialize changed to
JSContextcausing our issue.Would be nice to be able to detect the version at runtime which would allow us to continue to pass
JSGlobalContextfor old versions.Fixes #135
@appden