Don't require any GCDWebServers dependency when building Release #133
Conversation
| @@ -698,6 +696,7 @@ | |||
| FRAMEWORK_SEARCH_PATHS = ( | |||
| "$(inherited)", | |||
| "$(PROJECT_DIR)", | |||
| "$(BUILT_PRODUCTS_DIR)", | |||
There was a problem hiding this comment.
How did the linkage work before when this wasn't set?
There was a problem hiding this comment.
It was in the Link with Libraries build phase.
|
The GCDWebServers.framework is still being embedded into the RealmReact.framework in Release configuration. I think the easiest solution for that is to add a script immediately after the Embed Frameworks build phases that deletes the framework if |
|
As far as the Xcode project changes, my inclination would be to use |
|
@bdash great suggestion, thanks! |
|
|
|
|
||
| Ivar executorIvar = class_getInstanceVariable([bridge class], "_javaScriptExecutor"); | ||
| id executor = object_getIvar(bridge, executorIvar); | ||
| bool chromeDebugMode = [executor isMemberOfClass:NSClassFromString(@"RCTWebSocketExecutor")]; |
There was a problem hiding this comment.
Can we make this isKindOfClass: to be a little extra safe? :)
There was a problem hiding this comment.
isMemberOfClass is actually safer as we would catch any subclasses if the ReactNative implementation changed...
|
Looks good 👍 |
Don't require any GCDWebServers dependency when building Release
@appden
Fixes #132