Regression: Object.keys() no longer works on List objects in Chrome #80
Assignees
Labels
Comments
|
We should definitely add a test for Backing out for the time being seems fine. |
appden
added a commit
that referenced
this issue
Oct 21, 2015
Rather than using Object.preventExtensions to throw exceptions when setting any out-of-bounds index, we must instead compromise by only throwing for the common cases, which are -1 and list.length. Having Object.keys() support is essential for List to work with React Native ListViewDataSource. Resolves #80
alazier
pushed a commit
that referenced
this issue
Jun 14, 2016
Add backlink property support functionality
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This was broken by f2c4e78. It's important to have working because React Native
ListViewDataSourcerelies onObject.keys, and therefore our example app no longer works when debugging it in Chrome. Unfortunately, I can't figure out a way to continue to useObject.preventExtensions(so that we throw exceptions on setting out-of-bounds indices) and haveObject.keyswork properly withList.Until a eureka moment strikes me, I propose that we back out that commit and helpfully throw an exception when setting to
list[-1]andlist[list.length]in Chrome.The text was updated successfully, but these errors were encountered: