Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device tests to ci #59

Open
alazier opened this issue Oct 13, 2015 · 0 comments
Open

Add device tests to ci #59

alazier opened this issue Oct 13, 2015 · 0 comments
Labels
Pipeline-Idea-Backlog T-Test

Comments

@alazier
Copy link
Contributor

alazier commented Oct 13, 2015 •
edited by sync-by-unito bot
Loading

Right now we only test on simulator
alazier pushed a commit that referenced this issue Sep 14, 2016
@fealebenpae
Fix linking the node binding on linux (#59)
120eaba 
* Fix linking the node binding on linux

It turns out that because of the way GYP invokes the GNU linker on Linux we can’t add library dependencies in the `ldflags` dict key. We needed to do that in the first place because we can’t define a `libraries` dict key inside a `configurations` dict.

The workaround is to stop relying on the `configurations` dict for setting up linking against `librealm-node-dbg.a` vs. `librealm-node.a`. Instead, this patch introduces a new environment variable - `REALMJS_USE_DEBUG_CORE`, that, when set to any value during node-gyp’s configuration phase, would instruct GYP to link against the debug realm libraries instead.

* make sure the linker flag for sync is before the one for core
@dipanshujindal1992 dipanshujindal1992 mentioned this issue Jul 1, 2021
Closed
This was referenced Mar 15, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pipeline-Idea-Backlog T-Test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alazier @bmunkholm