Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate/Cleanup object_store code #48

Closed
appden opened this issue Oct 12, 2015 · 1 comment
Closed

Consolidate/Cleanup object_store code #48

appden opened this issue Oct 12, 2015 · 1 comment
Assignees

Comments

@appden
Copy link
Contributor

appden commented Oct 12, 2015

Right now we check for realm->is_in_transaction() inside object_accessor code for settings properties and creating new objects, but in the JSC layer for deleting objects and mutating arrays. All of this checks should be inside the object_store layer, which may mean adding new C++ methods for deletion and mutations. This will be good anyways in order to have less code duplication inside the Node API.

Also, from @alazier:

We will want to define a new exception type for mutations outside of write transactions, as other platforms will need to catch this and possibly handle this specific cases anywhere we throw from the shared object store code.

@alazier alazier changed the title Consolidate code that checks for open transactions inside object_store layer Consolidate/Cleanup object_store code Oct 12, 2015
@alazier alazier self-assigned this Oct 12, 2015
@alazier
Copy link
Contributor

alazier commented Oct 12, 2015

We need to cleanup our object store changes and get them merged to the object store repo. This includes:

  • checking for transactions during mutations
  • common path for property getters
  • exception classes for common exceptions
  • pull out ObjectArray into its own class/file

@alazier alazier added the P1 label Oct 12, 2015
@alazier alazier removed the P1 label Nov 19, 2015
alazier pushed a commit that referenced this issue Sep 14, 2016
* Ïnital Jenkinsfile for sync

* Use the same checkout

* Fix compilation error

* Fix no such property exception

* Use the right directory

* Add test phase
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants