-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate/Cleanup object_store code #48
Comments
alazier
changed the title
Consolidate code that checks for open transactions inside object_store layer
Consolidate/Cleanup object_store code
Oct 12, 2015
We need to cleanup our object store changes and get them merged to the object store repo. This includes:
|
alazier
pushed a commit
that referenced
this issue
Sep 14, 2016
* Ïnital Jenkinsfile for sync * Use the same checkout * Fix compilation error * Fix no such property exception * Use the right directory * Add test phase
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now we check for
realm->is_in_transaction()
inside object_accessor code for settings properties and creating new objects, but in the JSC layer for deleting objects and mutating arrays. All of this checks should be inside the object_store layer, which may mean adding new C++ methods for deletion and mutations. This will be good anyways in order to have less code duplication inside the Node API.Also, from @alazier:
The text was updated successfully, but these errors were encountered: