Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting object creation from arrays of properties #112

Closed
alazier opened this issue Oct 29, 2015 · 1 comment · Fixed by #123
Closed

Stop supporting object creation from arrays of properties #112

alazier opened this issue Oct 29, 2015 · 1 comment · Fixed by #123

Comments

@alazier
Copy link
Contributor

alazier commented Oct 29, 2015

@appden thinks this is a bad idea.

appden added a commit that referenced this issue Nov 3, 2015
Property arrays are no longer allowed. This simplifies the API and makes code easier to read and maintain. All tests now pass in simulator and in Chrome.

Resolves #112
appden added a commit that referenced this issue Nov 4, 2015
Property arrays are no longer allowed. This simplifies the API and makes code easier to read and maintain. All tests now pass in simulator and in Chrome.

Resolves #112
@alazier alazier added the P2 label Nov 16, 2015
@alazier
Copy link
Contributor Author

alazier commented Nov 16, 2015

I think we should still support this. We should definitely change the schema definition to the more idiomatic version though.

@alazier alazier closed this as completed Nov 16, 2015
@alazier alazier removed the P2 label Nov 16, 2015
fealebenpae pushed a commit that referenced this issue Aug 2, 2016
Fix building with local versions of core, and enabling sanitizers
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant