RCORE-2198: Support for additional properties (#7519) #7886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial support for additional properties This will allow some initial experiments in the SDKs. This is not a fileformat breaking change as we just use already existing features. --------- Co-authored-by: Claus Rørbech <claus.rorbech@gmail.com> Co-authored-by: Kenneth Geisshirt <kenneth.geisshirt@mongodb.com>
jedelbo
changed the title
jedelbo
changed the title
Pull Request Test Coverage Report for Build jorgen.edelbo_392Details
💛 - Coveralls |
papafe
reviewed
Jul 16, 2024
| @@ -631,6 +631,30 @@ BinaryData Obj::_get<BinaryData>(ColKey::Idx col_ndx) const | |||
| return ArrayBinary::get(alloc.translate(ref), m_row_ndx, alloc); | |||
| } | |||
|
|
|||
| bool Obj::has_property(StringData prop_name) const | |||
There was a problem hiding this comment.
It would be useful to have a has_additional_property method.
[bindgen] Expose Obj::has_schema_property(), TableRef::get_column_key(), and Obj::set_any_by_name()
* Fix bindgen typo * Expose erase prop * Expose Obj::get_additional_properties() --------- Co-authored-by: Gagik Amaryan <gagik.amaryan@mongodb.com> Co-authored-by: Gagik Amaryan <me@gagik.co>
|
During last check-in we decided we allow opening a realm with a different relaxed schema configuration. In particular:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow some initial experiments in the SDKs. This is not a fileformat breaking change as we just use already existing features.
What, How & Why?
☑️ ToDos
bindgen/spec.yml, if public C++ API changed