Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2181 Add unit tests for DefaultSyncSocketProvider websocket functionality #7838

Closed
wants to merge 0 commits into from

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Jun 24, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3303

Details

  • 384 of 451 (85.14%) changed or added relevant lines in 4 files are covered.
  • 47 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.03%) to 91.005%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/util/async_future_adapter.hpp 56 68 82.35%
src/realm/sync/network/network_error.cpp 9 25 36.0%
test/test_sync_socket_provider.cpp 318 357 89.08%
Files with Coverage Reduction New Missed Lines %
test/test_all.cpp 2 75.82%
src/realm/query_expression.hpp 3 93.81%
src/realm/sync/noinst/client_impl_base.cpp 4 82.66%
src/realm/sync/noinst/server/server.cpp 5 73.63%
test/util/compare_groups.cpp 5 50.0%
src/realm/sync/network/network_ssl.hpp 8 84.14%
test/util/resource_limits.cpp 20 52.08%
Totals Coverage Status
Change from base Build 2434: 0.03%
Covered Lines: 215287
Relevant Lines: 236567

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3305

Details

  • 401 of 467 (85.87%) changed or added relevant lines in 5 files are covered.
  • 103 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.03%) to 90.947%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/util/async_future_adapter.hpp 56 68 82.35%
src/realm/sync/network/network_error.cpp 9 25 36.0%
test/test_sync_socket_provider.cpp 332 370 89.73%
Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 87.23%
src/realm/util/file.cpp 1 84.84%
test/test_query2.cpp 1 98.73%
src/realm/array_blobs_big.cpp 2 98.58%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/table_view.cpp 2 92.99%
test/test_all.cpp 2 75.82%
src/realm/sync/noinst/server/server.cpp 4 73.23%
test/util/compare_groups.cpp 5 50.0%
src/realm/sync/noinst/server/server_history.cpp 6 63.38%
Totals Coverage Status
Change from base Build 2434: -0.03%
Covered Lines: 215089
Relevant Lines: 236498

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 25, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3310

Details

  • 536 of 600 (89.33%) changed or added relevant lines in 5 files are covered.
  • 67 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.993%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/util/async_future_adapter.hpp 59 68 86.76%
src/realm/sync/network/network_error.cpp 15 31 48.39%
test/test_sync_socket_provider.cpp 458 497 92.15%
Files with Coverage Reduction New Missed Lines %
src/realm/mixed.cpp 1 86.75%
test/fuzz_tester.hpp 1 57.73%
test/test_query2.cpp 1 98.73%
test/test_all.cpp 2 75.82%
src/realm/query_expression.hpp 3 93.84%
src/realm/sync/noinst/server/server.cpp 3 73.71%
test/fuzz_group.cpp 5 48.17%
test/object-store/util/sync/baas_admin_api.cpp 5 84.93%
test/util/compare_groups.cpp 5 50.0%
src/realm/sync/noinst/client_impl_base.cpp 6 82.46%
Totals Coverage Status
Change from base Build 2434: 0.02%
Covered Lines: 215315
Relevant Lines: 236628

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 25, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3332

Details

  • 522 of 600 (87.0%) changed or added relevant lines in 7 files are covered.
  • 73 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+0.3%) to 91.319%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/sync/noinst/server/server.cpp 0 3 0.0%
src/realm/util/async_future_adapter.hpp 39 45 86.67%
src/realm/sync/network/network_error.cpp 13 31 41.94%
test/test_sync_socket_provider.cpp 461 512 90.04%
Files with Coverage Reduction New Missed Lines %
src/realm/sync/network/network.hpp 1 95.72%
test/test_index_string.cpp 1 93.48%
test/test_query2.cpp 1 98.73%
src/realm/db.cpp 2 92.05%
src/realm/table_view.cpp 2 92.99%
src/realm/unicode.cpp 3 83.83%
test/object-store/util/sync/baas_admin_api.cpp 5 84.93%
src/realm/util/file.cpp 6 84.26%
src/realm/bplustree.cpp 7 71.41%
src/realm/index_string.cpp 8 84.63%
Totals Coverage Status
Change from base Build 2434: 0.3%
Covered Lines: 216974
Relevant Lines: 237600

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 26, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3333

Details

  • 534 of 612 (87.25%) changed or added relevant lines in 7 files are covered.
  • 107 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.997%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/sync/noinst/server/server.cpp 0 3 0.0%
src/realm/util/async_future_adapter.hpp 47 53 88.68%
src/realm/sync/network/network_error.cpp 15 31 48.39%
test/test_sync_socket_provider.cpp 464 517 89.75%
Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 87.23%
src/realm/sort_descriptor.cpp 1 94.06%
src/realm/sync/network/websocket.cpp 1 73.6%
src/realm/util/file.cpp 1 84.84%
src/realm/util/serializer.cpp 1 90.43%
test/test_query2.cpp 1 98.73%
src/realm/array_blobs_big.cpp 2 98.58%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/table_view.cpp 2 92.99%
test/test_all.cpp 2 75.82%
Totals Coverage Status
Change from base Build 2434: 0.02%
Covered Lines: 215275
Relevant Lines: 236575

💛 - Coveralls

Copy link

coveralls-official bot commented Jun 26, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3341

Details

  • 578 of 656 (88.11%) changed or added relevant lines in 8 files are covered.
  • 125 unchanged lines in 25 files lost coverage.
  • Overall coverage increased (+0.01%) to 90.989%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/sync/noinst/server/server.cpp 0 3 0.0%
src/realm/util/async_future_adapter.hpp 47 53 88.68%
src/realm/sync/network/network_error.cpp 15 31 48.39%
test/test_sync_socket_provider.cpp 464 517 89.75%
Files with Coverage Reduction New Missed Lines %
src/realm/array_string.cpp 1 87.23%
src/realm/sync/network/websocket.cpp 1 73.6%
src/realm/util/file.cpp 1 84.84%
src/realm/util/serializer.cpp 1 90.43%
test/test_index_string.cpp 1 93.48%
test/test_query2.cpp 1 98.73%
src/realm/object-store/shared_realm.cpp 2 91.89%
src/realm/query_expression.cpp 2 86.62%
src/realm/sync/transform.cpp 2 60.99%
src/realm/table_view.cpp 2 92.99%
Totals Coverage Status
Change from base Build 2434: 0.01%
Covered Lines: 215303
Relevant Lines: 236625

💛 - Coveralls

Copy link

coveralls-official bot commented Jul 24, 2024

Pull Request Test Coverage Report for Build jonathan.reams_3393

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 68 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.008%) to 91.101%

Files with Coverage Reduction New Missed Lines %
src/realm/uuid.cpp 1 98.48%
src/realm/cluster.cpp 2 75.85%
src/realm/list.cpp 2 87.37%
src/realm/object-store/shared_realm.cpp 2 91.9%
src/realm/sync/network/http.hpp 2 82.27%
src/realm/sync/transform.cpp 2 61.08%
test/object-store/sync/flx_sync.cpp 2 98.35%
src/realm/util/future.hpp 3 95.94%
src/realm/util/assert.hpp 4 87.1%
src/realm/sync/noinst/server/server_history.cpp 5 62.59%
Totals Coverage Status
Change from base Build 2569: -0.008%
Covered Lines: 217389
Relevant Lines: 238624

💛 - Coveralls

@jbreams jbreams closed this Aug 16, 2024
@jbreams jbreams deleted the jbr/websocket_unit_tests branch August 16, 2024 13:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant