Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle uploading logs in evg tasks on feature branches #6826

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Jul 25, 2023

What, How & Why?

This just updates the evergreen config so object store tests don't fail on branches besides master. If you aren't on the "main" branch of the evergreen project it doesn't fill in the ${project} expansion which causes our s3 upload paths to be invalid. Since we now only have one evergreen project I think its safe to hardcode these paths and just rely on the ${branch} expansion to differentiate between branches. For an example of how this could fail you can look at this patch failure.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@cla-bot cla-bot bot added the cla: yes label Jul 25, 2023
@jbreams jbreams changed the base branch from feature/sync_error_unification to master July 25, 2023 18:31
@jbreams jbreams marked this pull request as ready for review July 25, 2023 18:34
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbreams jbreams merged commit 4941dd0 into master Jul 25, 2023
6 of 8 checks passed
@jbreams jbreams deleted the jbr/make_evg_branches_work branch July 25, 2023 18:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants