Comma rule does not get triggered in all situations #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (fixes a gap when there are consecutive comma violations) Fixing swiflint warnings Improving comma rule to support expressions that begin with the comma (fixes a gap when there are consecutive comma violations) For example, if the expression is 'let a = [1,2,3]', the previous comma rule regexp would consume '1,2' and the remaining ',3' would not be consumed by the regexp because it does not support something that begins with a comma.
… (fixes a gap when there are consecutive comma violations) Fixing swiflint warnings Improving comma rule to support expressions that begin with the comma (fixes a gap when there are consecutive comma violations) For example, if the expression is 'let a = [1,2,3]', the previous comma rule regexp would consume '1,2' and the remaining ',3' would not be consumed by the regexp because it does not support something that begins with a comma. Updating changelog.md Improving comma rule to support expressions that begin with the comma (fixes a gap when there are consecutive comma violations)
…hub.com/sadefigu/SwiftLint into CommaRuleImpromentConsecutiveViolations
sadefigu
changed the title
Current coverage is 85.72% (diff: 100%)
|
|
Thanks for the PR, @sadefigu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving comma rule to support expressions that begin with the comma. (fixes a gap when there are consecutive comma violations)
For example, if the expression is 'let a = [1,2,3]', the previous comma rule regexp would consume '1,2' and the remaining ',3' would not be consumed by the regexp because it does not support something that begins with a comma.