Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftUI: Prefer scaledToFit()/scaledToFill() over aspectRatio(contentMode:) #5768

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ikelax
Copy link
Contributor

@ikelax ikelax commented Aug 22, 2024

Adresses #5713.

@ikelax ikelax marked this pull request as draft August 22, 2024 21:20
@SwiftLintBot
Copy link

SwiftLintBot commented Aug 22, 2024

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 0.84s vs 0.82s on main (2% slower)
📖 Linting Alamofire with this PR took 1.15s vs 1.17s on main (1% faster)
📖 Linting Brave with this PR took 6.76s vs 6.85s on main (1% faster)
📖 Linting DuckDuckGo with this PR took 4.28s vs 4.34s on main (1% faster)
📖 Linting Firefox with this PR took 10.21s vs 10.54s on main (3% faster)
📖 Linting Kickstarter with this PR took 9.12s vs 8.8s on main (3% slower)
📖 Linting Moya with this PR took 0.48s vs 0.48s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.37s vs 2.28s on main (3% slower)
📖 Linting Nimble with this PR took 0.7s vs 0.69s on main (1% slower)
📖 Linting PocketCasts with this PR took 7.82s vs 7.83s on main (0% faster)
📖 Linting Quick with this PR took 0.4s vs 0.4s on main (0% slower)
📖 Linting Realm with this PR took 4.34s vs 4.42s on main (1% faster)
📖 Linting Sourcery with this PR took 2.18s vs 2.14s on main (1% slower)
📖 Linting Swift with this PR took 4.15s vs 4.09s on main (1% slower)
📖 Linting VLC with this PR took 1.15s vs 1.13s on main (1% slower)
📖 Linting Wire with this PR took 16.75s vs 16.4s on main (2% slower)
📖 Linting WordPress with this PR took 10.56s vs 10.49s on main (0% slower)

Here's an example of your CHANGELOG entry:

* SwiftUI: Prefer scaledToFit()/scaledToFill() over aspectRatio(contentMode:).  
  [ikelax](https://github.com/ikelax)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants