-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- rule added for avoiding redundant extensions resolve #5359 #5388
base: main
Are you sure you want to change the base?
Conversation
- new case added in non triggering example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short and easy. Well done!
CHANGELOG.md
Outdated
@@ -10,6 +10,10 @@ | |||
|
|||
#### Enhancements | |||
|
|||
* Add new `redundant_extension` rule that detect redundant extensions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Add new `redundant_extension` rule that detect redundant extensions. | |
* Add new `redundant_extension` rule that detects redundant extensions. | |
An extension is considered redundant if it does not define any | |
members, but only conformances. |
You need to rebase to get rid of the failing test. |
CHANGELOG.md
Outdated
@@ -10,6 +10,12 @@ | |||
|
|||
#### Enhancements | |||
|
|||
* Add new `redundant_extension` rule that detects redundant extensions. | |||
An extension is considered redundant if it does not define any | |||
members, but only conformances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two spaces are required here to enforce a line break in the rendered Markdown:
members, but only conformances. | |
members, but only conformances. |
* main: Use explicit version for Bundler (realm#5395) Add destination to xcodebuild test instructions (realm#5392) Support Swift version 5.9.2 (realm#5391)
I have synced the |
Merge is not the same as rebase. 😉 Danger fails because of merge commits which are undesirable. |
- new case added in non triggering example
… into redundant_extension * 'redundant_extension' of github.com:mzeeshanid/SwiftLint: - change log updated - change log updated - new example added - simplified logic - new case added in non triggering example - rule added for avoiding redundant extensions resolve realm#5359
This branch is messed up 🙃. I have created a new pull request with the same changes in a single commit. |
New rule added for avoiding redundant extensions based on: