-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to specify the proper active directory to docs #5260
base: main
Are you sure you want to change the base?
Conversation
I think these steps are already covered by this section, aren't they? |
No that is why I'm adding it to that section. Please search on Xcode select in that section and show me where it's mentioned. |
The section I mentioned definitely relates to it. The point is that Xcode must be installed; nothing more. SwiftLint looks for SourceKit at the locations listed there. That said, what might be left for the README is the fact that a full Xcode must be installed (preferably) at a default location. But this applies to all installation methods and should at most be mentioned there. |
Very good. Is these environment variables specified in the docs? If not would it be wise to specify? |
Yes, they are here. |
In the section titled "working with multiple swift versions"? |
Yes. |
So I only have one swift version installed. That section is a long way off from the initial installation instructions. Not to mention the section you referenced is not explicit to provide the correct procedure. With that said do you still feel the documentation does not need to be modified? After all this is a tool to make higher quality code and one aspect is that code be simplified and easier to understand, right? |
Yes, and one aspect of high quality is to avoid redundancy. I just want to make sure the README contains the relevant points but not more. If you think the section is too far away from the "Installation" section, link to it from there or move it. Fine with me, if you mention |
This in reference to this issue