Use alternate implementation of glob with globstar support #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted from https://gist.github.com/efirestone/ce01ae109e08772647eb061b3bb387c3 The implementation from Pathos seems buggy. Fixes #3891
2 tasks
|
FYI @funzin |
Generated by 🚫 Danger |
keith
approved these changes
Mar 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #3892 +/- ##
=======================================
Coverage 91.96% 91.97%
=======================================
Files 435 435
Lines 22073 22126 +53
=======================================
+ Hits 20300 20350 +50
- Misses 1773 1776 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This isn't thread-safe.
jpsim
deleted the
use-alternate-implementation-of-glob-with-globstar-support
branch
jpsim
added a commit
that referenced
this pull request
Mar 16, 2022
Adapted from https://gist.github.com/efirestone/ce01ae109e08772647eb061b3bb387c3 The implementation from Pathos seems buggy. Fixes #3891
coffmark
pushed a commit
to coffmark/SwiftLint
that referenced
this pull request
Apr 11, 2022
Adapted from https://gist.github.com/efirestone/ce01ae109e08772647eb061b3bb387c3 The implementation from Pathos seems buggy. Fixes realm#3891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from https://gist.github.com/efirestone/ce01ae109e08772647eb061b3bb387c3
The implementation from Pathos seems buggy.
Fixes #3891