-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Time Azure Pipelines #3825
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jpsim
commented
Jan 25, 2022
- Revert "Fix CI badges"
- Revert "Move remaining CI jobs to GitHub Actions (Move remaining CI jobs to GitHub Actions #3822)"
- Revert "Move SwiftLint Analyze CI job to GitHub Actions (Move SwiftLint Analyze CI job to GitHub Actions #3820)"
- Revert "Move CocoaPods CI jobs to GitHub Actions (Move CocoaPods CI jobs to GitHub Actions #3819)"
- Revert "Move SwiftPM CI jobs to GitHub Actions (Move SwiftPM CI jobs to GitHub Actions #3818)"
However Azure Pipelines has 10x the concurrency for macOS workers vs 5x for GitHub Actions (see Twitter) so I think we're better off sticking with Azure Pipelines until that situation improves. |
jpsim
added a commit
that referenced
this pull request
Jan 25, 2022
Yesterday I started moving SwiftLint's CI jobs from Azure Pipelines to GitHub Actions, which has nicer integrations with GitHub's web UI and feels nicer & more lightweight overall. However, GitHub Actions has a serious limitation compared to Azure Pipelines, which is that it only has 5x macOS job concurrency vs Azure's 10x ([see Twitter](https://twitter.com/simjp/status/1326592600393068546)). This leads to significant queuing when merging PRs or pushing to PRs in a short span, which is the main way I work on SwiftLint when catching up on PR/issue backlog every few months. A quick timing check showed that a PR using Azure Pipelines (#3825) took 26m 47s vs GitHub Actions (#3824) took 32m 31s. These PRs were opened at a time when no other CI jobs were running, so even though Azure Pipelines already took 6 minutes less to run than GitHub Actions, that difference would be even larger if there had been other PRs triggering CI jobs at the same time. So I think the best move for the project for the time being is to stay with Azure Pipelines for its CI. If GitHub ever increases its macOS concurrency to match Azure Pipelines's 10x we can explore this again.
jpsim
added a commit
that referenced
this pull request
Jan 25, 2022
Yesterday I started moving SwiftLint's CI jobs from Azure Pipelines to GitHub Actions, which has nicer integrations with GitHub's web UI and feels nicer & more lightweight overall. However, GitHub Actions has a serious limitation compared to Azure Pipelines, which is that it only has 5x macOS job concurrency vs Azure's 10x ([see Twitter](https://twitter.com/simjp/status/1326592600393068546)). This leads to significant queuing when merging PRs or pushing to PRs in a short span, which is the main way I work on SwiftLint when catching up on PR/issue backlog every few months. A quick timing check showed that a PR using Azure Pipelines (#3825) took 26m 47s vs GitHub Actions (#3824) took 32m 31s. These PRs were opened at a time when no other CI jobs were running, so even though Azure Pipelines already took 6 minutes less to run than GitHub Actions, that difference would be even larger if there had been other PRs triggering CI jobs at the same time. So I think the best move for the project for the time being is to stay with Azure Pipelines for its CI. If GitHub ever increases its macOS concurrency to match Azure Pipelines's 10x we can explore this again.
rcole34
pushed a commit
to rcole34/SwiftLint
that referenced
this pull request
Feb 22, 2022
Yesterday I started moving SwiftLint's CI jobs from Azure Pipelines to GitHub Actions, which has nicer integrations with GitHub's web UI and feels nicer & more lightweight overall. However, GitHub Actions has a serious limitation compared to Azure Pipelines, which is that it only has 5x macOS job concurrency vs Azure's 10x ([see Twitter](https://twitter.com/simjp/status/1326592600393068546)). This leads to significant queuing when merging PRs or pushing to PRs in a short span, which is the main way I work on SwiftLint when catching up on PR/issue backlog every few months. A quick timing check showed that a PR using Azure Pipelines (realm#3825) took 26m 47s vs GitHub Actions (realm#3824) took 32m 31s. These PRs were opened at a time when no other CI jobs were running, so even though Azure Pipelines already took 6 minutes less to run than GitHub Actions, that difference would be even larger if there had been other PRs triggering CI jobs at the same time. So I think the best move for the project for the time being is to stay with Azure Pipelines for its CI. If GitHub ever increases its macOS concurrency to match Azure Pipelines's 10x we can explore this again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.