Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DuplicateImportsRule's support for import attributes #3402

Merged

Conversation

keith
Copy link
Contributor

@keith keith commented Nov 5, 2020

No description provided.

@keith keith marked this pull request as ready for review November 5, 2020 01:39
@SwiftLintBot
Copy link

SwiftLintBot commented Nov 5, 2020

12 Messages
📖 Linting Aerial with this PR took 1.95s vs 1.88s on master (3% slower)
📖 Linting Alamofire with this PR took 2.75s vs 2.7s on master (1% slower)
📖 Linting Firefox with this PR took 9.29s vs 9.29s on master (0% slower)
📖 Linting Kickstarter with this PR took 15.47s vs 15.3s on master (1% slower)
📖 Linting Moya with this PR took 1.35s vs 1.3s on master (3% slower)
📖 Linting Nimble with this PR took 1.37s vs 1.37s on master (0% slower)
📖 Linting Quick with this PR took 0.6s vs 0.59s on master (1% slower)
📖 Linting Realm with this PR took 4.43s vs 4.39s on master (0% slower)
📖 Linting SourceKitten with this PR took 1.03s vs 1.02s on master (0% slower)
📖 Linting Sourcery with this PR took 7.22s vs 7.11s on master (1% slower)
📖 Linting Swift with this PR took 10.98s vs 10.91s on master (0% slower)
📖 Linting WordPress with this PR took 17.48s vs 17.37s on master (0% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #3402 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3402   +/-   ##
=======================================
  Coverage   90.50%   90.51%           
=======================================
  Files         420      420           
  Lines       20555    20557    +2     
=======================================
+ Hits        18604    18607    +3     
+ Misses       1951     1950    -1     
Impacted Files Coverage Δ
...amework/Rules/Idiomatic/DuplicateImportsRule.swift 98.21% <100.00%> (ø)
...Rules/Idiomatic/DuplicateImportsRuleExamples.swift 100.00% <100.00%> (ø)
...iftLintFramework/Extensions/String+SwiftLint.swift 94.54% <0.00%> (-1.82%) ⬇️
...tFramework/Rules/Lint/ValidIBInspectableRule.swift 100.00% <0.00%> (+1.35%) ⬆️
...ftLintFramework/Rules/Lint/PrivateOutletRule.swift 100.00% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6df1d3...d36ee15. Read the comment docs.

@keith keith requested a review from jpsim November 5, 2020 16:55
Copy link
Collaborator

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpsim jpsim merged commit 05344f5 into master Nov 5, 2020
@jpsim jpsim deleted the ks/fix-duplicateimportsrules-support-for-import-attributes branch November 5, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants