Use working directory as root path instead of trying to calculate it #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethfri
force-pushed
the
root-path-fix
branch
from
743c7bd to
0ecf908
Compare
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #3384 +/- ##
==========================================
- Coverage 90.51% 90.51% -0.01%
==========================================
Files 420 420
Lines 20555 20554 -1
==========================================
- Hits 18605 18604 -1
Misses 1950 1950
Continue to review full report at Codecov.
|
|
@jpsim This one's ready for your input! |
sethfri
force-pushed
the
root-path-fix
branch
from
30b2a6a to
ebaee73
Compare
jpsim
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently try to derive the root path by using the path passed in. However, this doesn't allow us to actually get the root, just the containing directory of the path passed in. We also don't currently have a heuristic to use for deriving the root path for multiple paths passed in.
The fix (which fixes #3383) is to remove our root path calculation and just use the current working directory as the root instead.